[U-Boot] [PATCH V4 4/4] VCMA9: various cleanups/code style fixes
Wolfgang Denk
wd at denx.de
Tue Apr 12 12:28:01 CEST 2011
Dear =?UTF-8?q?David=20M=C3=BCller?=,
In message <1302600759-28219-5-git-send-email-d.mueller at elsoft.ch> you wrote:
> --===============1758926862==
>
> Signed-off-by: David Müller <d.mueller at elsoft.ch>
>
> ---
> board/mpl/vcma9/cmd_vcma9.c | 4 +-
> board/mpl/vcma9/lowlevel_init.S | 549 ++++++++++++++++++++++++++++++---------
> board/mpl/vcma9/vcma9.c | 272 +++++---------------
> board/mpl/vcma9/vcma9.h | 117 +--------
> include/configs/VCMA9.h | 200 +++++++++------
> 5 files changed, 626 insertions(+), 516 deletions(-)
Where is the change log that shows what has been changed with this new
patch version? Please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
> -extern void print_vcma9_info(void);
> +extern void vcma9_print_info(void);
Please get rid of all such externs - move the prototype declarations
to appropriate header files. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is impractical for the standard to attempt to constrain the
behavior of code that does not obey the constraints of the standard.
- Doug Gwyn
More information about the U-Boot
mailing list