[U-Boot] [PATCH V4 1/4] VCMA9: activate ARM relocation feature

Wolfgang Denk wd at denx.de
Tue Apr 12 12:30:14 CEST 2011


Dear =?UTF-8?q?David=20M=C3=BCller?=,

In message <1302600759-28219-2-git-send-email-d.mueller at elsoft.ch> you wrote:
> --===============0390427290==
> 
> Signed-off-by: David Müller <d.mueller at elsoft.ch>
> 
> ---
>  include/configs/VCMA9.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/VCMA9.h b/include/configs/VCMA9.h
> index ebe9e42..b723908 100644
> --- a/include/configs/VCMA9.h
> +++ b/include/configs/VCMA9.h
> @@ -247,4 +247,10 @@
>  
>  #define MULTI_PURPOSE_SOCKET_ADDR 0x08000000
>  
> +/* additions for new relocation code, must added to all boards */

I don't see much sense in such a comment. "New relocation code" is not
generally meaningful, and "must be added" is not only missing a "be"
but also redundant as you just added the code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"He only drinks when he gets depressed." "Why does he get depressed?"
"Sometimes it's because he hasn't had a drink."
                                     - Terry Pratchett, _Men at Arms_


More information about the U-Boot mailing list