[U-Boot] [PATCH] gpio: generalize for all generic gpio providers

Mike Frysinger vapier at gentoo.org
Tue Apr 12 18:14:01 CEST 2011


On Tuesday, April 12, 2011 09:13:35 Andreas Pretzsch wrote:
> Am Montag, den 11.04.2011, 23:14 -0400 schrieb Mike Frysinger:
> > On Monday, April 11, 2011 15:34:17 Andreas Pretzsch wrote:
> > > Am Sonntag, den 03.04.2011, 04:43 -0400 schrieb Mike Frysinger:
> > > > +	return port_base + simple_strtoul(name, NULL, 10);
> > > 
> > > Remark: Leads to an oom access when exceeding the processor number of
> > > GPIOs, e.g. PF48 on a BF561. IMHO, no problem but only a cosmetic
> > > issue, not worth adding an additional per-cpu check.
> > > In the end, no difference to other user errors like an invalid memory
> > > address.
> > 
> > err, oom ?  i guess you mean oob ?
> 
> bfin> gpio input PF0
> gpio: pin PF0 (gpio 0) value is 1
> bfin> gpio input pf47
> gpio: pin pf47 (gpio 47) value is 1
> bfin> gpio input pf48
> DCPLB exception outside of memory map at 0x33000000
> [...]
> PANIC: Blackfin internal error

"oom" is usually reserved for "out of memory" as in "memory exhausted"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110412/b6806b24/attachment.pgp 


More information about the U-Boot mailing list