[U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing
Wolfgang Denk
wd at denx.de
Tue Apr 12 22:17:51 CEST 2011
Dear Kyle Moffett,
In message <1297467482-14864-3-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> By allocating the e1000 device structures much earlier, we can easily
> generate better error messages and siginficantly clean things up.
>
> The only user-visable change (aside from reworded error messages) is
> that a detected e1000 device which fails to initialize due to software
> or hardware error will still be allocated a device number.
>
> As one example, consider a system with 2 e1000 PCI devices where the
> first controller has a corrupted EEPROM. Using the old code the
> second controller would be "e1000#0", while with this change it would be
> "e1000#1".
>
> This change should hopefully make such EEPROM errors much more
> straightforward to handle correctly in boot scripts and the like.
>
> It is also necessary for a followup patch which allows SPI programming
> of an e1000 controller's EEPROM even if the checksum is invalid.
This patch has a number of overlong lines. Please globally fix the
line length.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.
More information about the U-Boot
mailing list