[U-Boot] [PATCH 1/2] ARMV7: Adding support for Samsung SMDKV310 Board

[Minkyu Kang]

Dear Chander Kashyap,

On 11 April 2011 19:49, Chander Kashyap <chander.kashyap at linaro.org> wrote:
>> > SMDKV310 board is based on Samsung S5PV310 SOC. This SOC is very much
>> > similar to S5PC210.
>> >
>> > Signed-off-by: Chander Kashyap <chander.kashyap at linaro.org>
>> > Signed-off-by: Tushar Behera <tushar.behera at linaro.org>
>> > ---
>> >  board/samsung/smdkv310/Makefile        |   46 +++
>> >  board/samsung/smdkv310/config.mk       |    1 +
>> >  board/samsung/smdkv310/lowlevel_init.S |  549
>> > +++++++++++++++++++++++++++
>> >  board/samsung/smdkv310/mem_setup.S     |  632
>> > ++++++++++++++++++++++++++++++++
>> >  board/samsung/smdkv310/smdkv310.c      |  138 +++++++
>> >  boards.cfg                             |    1 +
>> >  include/configs/smdkv310.h             |  199 ++++++++++
>> >  7 files changed, 1566 insertions(+), 0 deletions(-)
>> >  create mode 100644 board/samsung/smdkv310/Makefile
>> >  create mode 100644 board/samsung/smdkv310/config.mk
>> >  create mode 100644 board/samsung/smdkv310/lowlevel_init.S
>> >  create mode 100644 board/samsung/smdkv310/mem_setup.S
>> >  create mode 100644 board/samsung/smdkv310/smdkv310.c
>> >  create mode 100644 include/configs/smdkv310.h
>>
>> You missing MAINTAINER entry.
>
> I did  not got this. Where to put maintainer entry.
>

Please see MAINTAINERS.

>> > +       /* Memory initialize */
>> > +       bl mem_ctrl_asm_init
>>
>> Is it OK that memory initialize on u-boot?
>> Maybe only do on mmc spl?
>
> This is generic initialisation Code.  We need this in case of NOR boot. This
> initialisation
> is excluded in case of SPL boot.

How about eMMC boot or OneNAND boot?
Maybe DRAM will be initialized twice, and then system will be hang.
I think need to add ifdef condition.

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net