[U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

[Mike Frysinger]

On Tuesday, April 12, 2011 20:46:08 Simon Glass wrote:
> +static int turbo_mode = 1;

perhaps this should be a #define ?  i cant see anything that changes its value 
in this driver ...

> +static void smsc95xx_halt(struct eth_device *eth)
> +{
> +	debug("** %s()\n", __func__);
> +}

is this right ?  shouldnt you be halting something ?

> +/*
> + * SMSC probing functions
> + */
> +void smsc95xx_eth_before_probe(void)
> +{
> +	curr_eth_dev = 0;
> +}

curr_eth_dev is declared static which means it starts off with a value of 0.  
when does before_probe get called ?  just once ever during the execution of u-
boot ?  i guess this func should get tossed if that's the case.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110412/88b6bd4c/attachment.pgp