[U-Boot] [PATCH 1/3] ARM: don't panic if no flash is there

[Wolfgang Denk]

Dear Alessandro Rubini,

In message <7edfdbf8df20140ad93f0a967fc526f8cef5360d.1303028702.git.rubini at gnudd.com> you wrote:
> From: Alessandro Rubini <rubini at gnudd.com>
> 
> Commit f1d2b313c9eb6808d30c16a9eb5251240452a56c, which
> introduced relocation, also added some ifdef to panic
> for no flash is found but some is expected.  This is policy,
> in my opinion, and should not be part of the boot loader
> like it wasn't there earlier.
> 
> This is mandatory to have the versatile port work on qemu,
> where flash has never been correctly identified without any
> side effect on the usefulness of the emulation.
> 
> Signed-off-by: Alessandro Rubini <rubini at gnudd.com>
> ---
>  arch/arm/lib/board.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)

Sorry, but I reject this patch.  This is common code that has always
been there (at least in the reference implementation on Power; it was
a bug that got fixed that this was missing before in ARM).

If you do not have NOR flash, then you should not enable it (and
define CONFIG_SYS_NO_FLASH). Otherwise, you are supposed to have
flash memory.

If there are problems with the Qemu emulation of NOR flash these
should be fixed there.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see but you do not observe.
Sir Arthur Conan Doyle, in "The Memoirs of Sherlock Holmes"