[U-Boot] [PATCH v3 2/3] MX31: Introduce get_reset_cause()

[Detlev Zundel]

Hi Fabio and Stefan,

> On 04/15/2011 04:21 AM, Fabio Estevam wrote:
>> Introduce get_reset_cause() function to indicate the source of the reset.
>> 
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> ---
>>  arch/arm/cpu/arm1136/mx31/generic.c       |   26 ++++++++++++++++++++++++++
>>  arch/arm/include/asm/arch-mx31/imx-regs.h |    2 ++
>>  2 files changed, 28 insertions(+), 0 deletions(-)
>> 
>
> Hi Fabio,
>
>> diff --git a/arch/arm/include/asm/arch-mx31/imx-regs.h
>> b/arch/arm/include/asm/arch-mx31/imx-regs.h
>> index 74444f2..2b0881d 100644
>> --- a/arch/arm/include/asm/arch-mx31/imx-regs.h
>> +++ b/arch/arm/include/asm/arch-mx31/imx-regs.h
>> @@ -27,6 +27,8 @@
>>  #if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
>>  #include <asm/types.h>
>>  
>> +extern char *get_reset_cause(void);
>> +
>
> The imx-regs.h contains only defines and structures for the processor,
> and no prototypes. Function prototypes are then listed in sys_proto.h,
> not only for i.MX processor. I prefer to maintain this rule and to not
> add prototypes to this file.

Why can't we have this code in the cpu specific code _without_ any call
from a board so _ecery_ board gets the additional information for free?

See for example arch/powerpc/cpu/mpc512x/cpu.c where this is done for
RSR on 5121.  I do not understand what the problem is here, can someone
enlighten me please?

Cheers
  Detlev

-- 
The X approach to device independence is to treat everything like a MicroVAX
framebuffer on acid.
                                          -- The UNIX Haters Handbook
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de