[U-Boot] [PATCH] PowerPC: Move -fPIC flag to common place

Wolfgang Denk wd at denx.de
Wed Apr 20 22:13:35 CEST 2011


Dear Joakim Tjernlund,

In message <OF8B32E14F.150B51B9-ONC1257878.0044927E-C1257878.00452684 at transmode.se> you wrote:
>
> OK, I managed to script the change, patch last in mail.

Thanks.

> However CROSS_COMPILE=powerpc-softfloat-linux-gnu- ./MAKEALL  TQM862L TQM855L TQM860L
> does not build for me, same problem as you got.
> Even if I manually back out the 2 patches affecting 8xx it wont build.
> I think these boards have some other problem really, like u-boot is too big for them.
> 
> Most other 8xx boards build fine, those that don't have some other problem.

I bisected the build issue, and it pointed at your patch.


> From ce7970dd177a798c5ab7e093adadfc57a97ce0e7 Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> Date: Wed, 20 Apr 2011 14:22:59 +0200
> Subject: [PATCH] powerpc, 8xx: Fixup all 8xx u-boot.lds scripts
> 
> 8xx was left behind when fixing up powerpc linking
> scripts to support -fpic.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> ---
>  board/LEOX/elpt860/u-boot.lds        |    5 +++--
>  board/RPXClassic/u-boot.lds          |    5 +++--
>  board/RPXlite/u-boot.lds             |    5 +++--
>  board/RPXlite_dw/u-boot.lds          |    5 +++--
>  board/RRvision/u-boot.lds            |    5 +++--
>  board/adder/u-boot.lds               |    5 +++--
>  board/amirix/ap1000/u-boot.lds       |    5 +++--
>  board/c2mon/u-boot.lds               |    5 +++--
>  board/cogent/u-boot.lds              |    5 +++--
>  board/dave/PPChameleonEVB/u-boot.lds |    3 ++-
>  board/eltec/mhpc/u-boot.lds          |    5 +++--
>  board/emk/top860/u-boot.lds          |    5 +++--
>  board/ep88x/u-boot.lds               |    3 ++-
>  board/esd/dasa_sim/u-boot.lds        |    5 +++--
>  board/esteem192e/u-boot.lds          |    5 +++--
>  board/etx094/u-boot.lds              |    5 +++--
>  board/evb64260/u-boot.lds            |    5 +++--
>  board/fads/u-boot.lds                |    5 +++--
>  board/flagadm/u-boot.lds             |    5 +++--
>  board/gen860t/u-boot.lds             |    5 +++--
>  board/genietv/u-boot.lds             |    5 +++--
>  board/hermes/u-boot.lds              |    5 +++--
>  board/hymod/u-boot.lds               |    2 +-
>  board/icu862/u-boot.lds              |    5 +++--
>  board/ip860/u-boot.lds               |    5 +++--
>  board/ivm/u-boot.lds                 |    5 +++--
>  board/kup/kup4k/u-boot.lds           |    5 +++--
>  board/kup/kup4x/u-boot.lds           |    5 +++--
>  board/lantec/u-boot.lds              |    5 +++--
>  board/lwmon/u-boot.lds               |    5 +++--
>  board/manroland/uc100/u-boot.lds     |    5 +++--
>  board/matrix_vision/mvsmr/u-boot.lds |    3 ++-
>  board/mbx8xx/u-boot.lds              |    5 +++--
>  board/ml2/u-boot.lds                 |    5 +++--
>  board/mousse/u-boot.lds              |    5 +++--
>  board/mvblue/u-boot.lds              |    5 +++--
>  board/netphone/u-boot.lds            |    5 +++--
>  board/netta/u-boot.lds               |    5 +++--
>  board/netta2/u-boot.lds              |    5 +++--
>  board/netvia/u-boot.lds              |    5 +++--
>  board/nx823/u-boot.lds               |    5 +++--
>  board/quantum/u-boot.lds             |    5 +++--
>  board/r360mpi/u-boot.lds             |    5 +++--
>  board/rbc823/u-boot.lds              |    5 +++--
>  board/rmu/u-boot.lds                 |    5 +++--
>  board/rsdproto/u-boot.lds            |    2 +-
>  board/sandpoint/u-boot.lds           |    5 +++--
>  board/sc3/u-boot.lds                 |    5 +++--
>  board/siemens/IAD210/u-boot.lds      |    5 +++--
>  board/sixnet/u-boot.lds              |    5 +++--
>  board/snmc/qs850/u-boot.lds          |    5 +++--
>  board/snmc/qs860t/u-boot.lds         |    5 +++--
>  board/spc1920/u-boot.lds             |    5 +++--
>  board/spd8xx/u-boot.lds              |    5 +++--
>  board/stx/stxxtc/u-boot.lds          |    5 +++--
>  board/svm_sc8xx/u-boot.lds           |    5 +++--
>  board/tqc/tqm8xx/u-boot.lds          |    5 +++--
>  board/v37/u-boot.lds                 |    5 +++--
>  board/westel/amx860/u-boot.lds       |    5 +++--
>  59 files changed, 170 insertions(+), 113 deletions(-)

Thanks, applied.

Problem is still present.

Bisected again:

39768f7715ed637ef02f49fc7de664cc1aaf14b3 is the first bad commit
commit 39768f7715ed637ef02f49fc7de664cc1aaf14b3
Author: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
Date:   Mon Dec 6 18:35:37 2010 +0100

    PowerPC: Add support for -msingle-pic-base


I revert this commit now.  Result:

-> ./MAKEALL TQM860L
Configuring for TQM860L board...
u-boot.lds:75 cannot move location counter backwards (from 40008024 to 40008000)
make: *** [u-boot] Error 1
ppc_8xx-size: './u-boot': No such file

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with warnings or errors: 1 ( TQM860L )
----------------------------------------------------------
-> git revert 39768f7715ed637ef02f49fc7de664cc1aaf14b3
[master 8c4734e] Revert "PowerPC: Add support for -msingle-pic-base"
 13 files changed, 12 insertions(+), 127 deletions(-)
-> ./MAKEALL TQM860L
Configuring for TQM860L board...
   text    data     bss     dec     hex filename
 258127   14768   27228  300123   4945b ./u-boot

--------------------- SUMMARY ----------------------------
Boards compiled: 1
----------------------------------------------------------


Please feel free to resubmit when this commit does not cause problems
any more.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real Programmers always confuse Christmas and Halloween because
OCT 31 == DEC 25 !  - Andrew Rutherford (andrewr at ucs.adelaide.edu.au)


More information about the U-Boot mailing list