[U-Boot] [PATCH 0/5] Add target EDOSK2674

[Wolfgang Denk]

Dear Yoshinori Sato,

In message <87zkpe9dj9.wl%ysato at users.sourceforge.jp> you wrote:
> Hi lists,
> 
> This patches added new target EDOSK2674.
> Please comments.
> Thanks.

As a general note, it would be a good idea to include some comments
about hwat sort this CPU is, why it is implemented here as a new
architecture, where one can find related documentation, etc.

> Yoshinori Sato (5):
>   Add h8300 architecture part1 - core
>   Add h8300 architecture part2 - headers
>   Add h8300 architecture part3 - misc
>   standard SCI support
>   Add target edosk2674

This split is artifical and makes no sense.  Please keep in ind that
commits shall implement atomic changes, always resulting in some sort
of sane state. So adding code without the needed headers is a strict
no-no.

Finally, these changes have a number of style issues.  In a first step
I recommend to clean up checkpatch errors and warnings:

[U-Boot] [PATCH 1/5] Add h8300 architecture part1 - core
total: 6 errors, 9 warnings, 716 lines checked
[U-Boot] [PATCH 2/5] Add h8300 architecture part2 - headers
total: 84 errors, 84 warnings, 796 lines checked
[U-Boot] [PATCH 3/5] Add h8300 architecture part3 - misc
total: 1 errors, 11 warnings, 104 lines checked
[U-Boot] [PATCH 4/5] standard SCI support
total: 9 errors, 3 warnings, 273 lines checked
[U-Boot] [PATCH 5/5] Add target edosk2674
total: 8 errors, 11 warnings, 442 lines checked

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: Why do PCs have a reset button on the front?
A: Because they are expected to run Microsoft operating systems.