[U-Boot] Policy for checkpatch usage?

Fabian Cenedese Cenedese at indel.ch
Thu Apr 21 16:56:36 CEST 2011


At 10:49 21.04.2011 -0400, Eric Cooper wrote:
>On Thu, Apr 21, 2011 at 04:29:17PM +0200, Detlev Zundel wrote:
>> What about the problem with checkpatch errors in current code, i.e. the
>> origin of this sentence:
>> 
>>   Also warnings produced for context lines (i.e. existing code) rather
>>   than actual changes can also be ignored.
>
>How about replacing it with this:
>
>    If you encounter warnings for existing code, not modified by your
>    patch, consider submitting a separate, cosmetic-only patch --
>    clearly described as such -- that *precedes* your substantive
>    patch.

Is that even possible? The cosmetic patch itself will be surrounded
by context lines which may fire up a warning. So these lines need
to be changed as well to satisy checkpatch. But this new patch
will again include several context lines... until you have to fix up the
whole file. Or did I misunderstand?

bye  Fabi



More information about the U-Boot mailing list