[U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

Stefano Babic sbabic at denx.de
Thu Apr 21 18:01:06 CEST 2011


On 04/15/2011 08:07 PM, Stefano Babic wrote:
> On 04/12/2011 04:18 AM, Fabio Estevam wrote:
>> Use the same method of the Linux kernel to print the MX31 silicon version on 
>> boot.
>>
>> Tested on a MX31PDK with a 2.0 silicon, where it shows:
>>
>> CPU:   Freescale i.MX31 rev 2.0 at 531 MHz
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>>
> 
> Applied to u-boot-imx, thanks.
> 

Fabio,

I have not noted before that your patch introduce a warning:

generic.c: In function 'get_cpu_rev':
generic.c:131: warning: return discards qualifiers from pointer target type

This is due to the usage of the const in the mx3_cpu_type:

struct mx3_cpu_type {
        u8 srev;
       const char *v;

Do you agree if I drop myself the const attribute on u-boot-imx before
pulling your patch to the arm tree ?

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list