[U-Boot] [PATCH] powerpc/85xx: Integrated Flash Controller NAND support

Scott Wood scottwood at freescale.com
Mon Apr 25 19:32:15 CEST 2011


On Mon, 25 Apr 2011 04:06:10 +0000
Dudhat Dipen-B09055 <B09055 at freescale.com> wrote:

> Hi Wolfgang,
> 
> Any comments on this patch...
> 
> This patch is acked by kumar gala.

There's still been no patch posted for a board that enables this driver.  It
would be nice to have the ability to at least see if this compiles
without warnings before applying it.

> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  
> +USA  */

Fix the formatting here.

> +
> +static uint32_t get_sram_addr(int page_no, int page_size) {
[snip]
> +static void nand_load(unsigned int offs, int uboot_size, uchar *dst) {

The brace that begins a function definition should go on its own line
(same applies throughout the patch).

-Scott



More information about the U-Boot mailing list