[U-Boot] [PATCH] powerpc/85xx: Integrated Flash Controller NAND support

Scott Wood scottwood at freescale.com
Mon Apr 25 21:09:41 CEST 2011


On Mon, 25 Apr 2011 21:01:26 +0200
Wolfgang Denk <wd at denx.de> wrote:

> Dear Scott Wood,
> 
> In message <20110425123215.004cd5c8 at schlenkerla.am.freescale.net> you wrote:
> >
> > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  
> > > +USA  */
> > 
> > Fix the formatting here.
> > 
> > > +
> > > +static uint32_t get_sram_addr(int page_no, int page_size) {
> > [snip]
> > > +static void nand_load(unsigned int offs, int uboot_size, uchar *dst) {
> > 
> > The brace that begins a function definition should go on its own line
> > (same applies throughout the patch).
> 
> 
> When requesting such changes, could you please also change the status
> of the patch in Patchwork?  It would really help me a lot if all
> custodians could do this consequently with all patches they comment.

Done -- sorry for forgetting, I usually try to keep patchwork updated.

-Scott



More information about the U-Boot mailing list