[U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

[Stefano Babic]

On 04/27/2011 04:57 PM, Detlev Zundel wrote:
> I see.  Can't we consolidate all those functions into more general
> functions higher up in the specialization graph?

As I can see, the get_cpu_rev() is already a generalized function, used
in more processors. IMHO we should switch back to the usual prototype
u32 get_cpu_rev(), and print_cpuinfo() should transform the revision
number in a human readable way.

>  I.e. why have static
> non-conforming functions when we could have one generic function to
> handle all users?

Yes, agree. Really I have not seen that get_cpu_rev() changed returning
a string, instead of u32 as usual. This must be fixed.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================