[U-Boot] [PATCH v2] lib/hashtable: fix env var autocompletion

Wolfgang Denk wd at denx.de
Thu Apr 28 00:55:29 CEST 2011


Dear Kim Phillips,

In message <20110405121450.099cb324.kim.phillips at freescale.com> you wrote:
> commit c81c1222427f268d29ba999c82e2477c428e7bab "Fix hash
> table deletion to prevent lost entries" broke environment
> variable autocompletion by accidentally inverting the
> condition for 'used' in hmatch_r().
> 
> 'used' is 0 if the hash table entry is not used, or -1 if deleted.
> This patch makes hmatch_r actually match on valid ('used') entries,
> instead of skipping them and failing to match anything.
> 
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
> v2: fix commit message to point to correct source of failure

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Beware of the Turing Tar-pit in  which  everything  is  possible  but
nothing of interest is easy.


More information about the U-Boot mailing list