[U-Boot] [PATCH] [v2] powerpc: fix implementation of out_8 to match the other out_XX functions

Wolfgang Denk wd at denx.de
Thu Apr 28 00:56:28 CEST 2011


Dear Timur Tabi,

In message <1301952064-1418-1-git-send-email-timur at freescale.com> you wrote:
> For some reason, the implementation of out_8() does not match the other
> output accessors, nor does it match equivalent Linux accessor.  This can
> cause a problem in a situation like this:
> 
> 	__raw_readb(p1);
> 	out_8(p2, x);
> 
> In this case, there is no barrier between the read and the write.
> If the out_8() is changed to out_be16(), then there is a barrier.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>  arch/powerpc/include/asm/io.h |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You don't need a weatherman to know which way the wind blows.
                                                          - Bob Dylan


More information about the U-Boot mailing list