[U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

Wolfgang Denk wd at denx.de
Fri Apr 29 12:20:36 CEST 2011


Dear Andy Fleming,

In message <BANLkTi=+tGpet6BDHiY_7Xx2dyiDbcu9DQ at mail.gmail.com> you wrote:
>
> It's just that the other way would also be possible. I re-read the
> thread where this was discussed, and while I definitely agree that the
> originally proposed solution was highly error-prone, I think
> *allowing* users to do this is fine:
> 
> mmc read <dev>:<part> <addr> <blk> <cnt>
> 
> Is there a reason that this wouldn't work with the current model?

Of course it works, but I don't like it:

- I think different user interfaces for the same thing are usually
  confusing.
- Defining a policy will be necessay, and even then it may cause side
  effects. For example, does "mmc read <dev>:<part> ..." change the
  "current" device settings, or are these only temporarily active
  while the command is running? etc.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every living thing wants to survive.
	-- Spock, "The Ultimate Computer", stardate 4731.3


More information about the U-Boot mailing list