[U-Boot] [PATCH] [v2] powerpc/85xx: fix compatible property for the L2 cache node

Wolfgang Denk wd at denx.de
Fri Apr 29 22:33:55 CEST 2011


Dear Kumar Gala,

In message <8188C4AC-9553-4F2D-9370-9416D63AF6A7 at freescale.com> you wrote:
> 
> On Apr 29, 2011, at 9:58 AM, Timur Tabi wrote:
> 
> > The compatible property for the L2 cache node (on 85xx systems that don't
> > have a CPC) was using a value for the property length that did not match
> > the actual length of the property.
> > 
> > Signed-off-by: Timur Tabi <timur at freescale.com>
> > ---
> > arch/powerpc/cpu/mpc85xx/fdt.c |   13 +++++++------
> > 1 files changed, 7 insertions(+), 6 deletions(-)
> 
> applied to 85xx

Kumar, don't you think that 32 minutes of review time is way too long
for such a patch??  Maybe we should stop doing code reviews, and just
accept all crap that gets posted here.

Hey, we could automate this and have lots of free time instead.

NAK!!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ernest asks Frank how long he has been working for the company.
        "Ever since they threatened to fire me."


More information about the U-Boot mailing list