[U-Boot] [RFC] ks8851_mll: add ethernet support

[Mike Frysinger]

On Wednesday, March 16, 2011 05:17:19 Raffaele Recalcati wrote:
> This driver has been adapted to u-boot starting from ks8851_mll linux
> driver. The smsc911x u-boot has been used as reference.

if you're basing this driver on other code, then the copyright info in the 
header should be preserved from the other files

> +static inline void ks_read_qmu(struct eth_device *dev, u16 *buf, u32 len)
> +{

this is a fairly fat func to be forcing inline.  in general, let gcc handle 
the optimization and only use "inline" when you really really need it.

> +int ks8851_mll_register(u8 dev_num, int base_addr)
> +{
> ...
> +	dev->init = ks8851_mll_init;
> +	dev->halt = ks8851_mll_halt;
> +	dev->send = ks8851_mll_send;
> +	dev->recv = ks8851_mll_rx;

missing dev->write_hwaddr

> --- /dev/null
> +++ b/drivers/net/ks8851_mll.h
> +static const struct chip_id chip_ids[] =  {
> +	{ CIDER_ID, "KSZ8851" },
> +	{ 0, NULL },
> +};

headers should not be defining variables.  this belongs in the .c file.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110430/6daca6fc/attachment.pgp