[U-Boot] [PATCH] MatrixVision common code: use getenv_f instead of snprintf.
Wolfgang Denk
wd at denx.de
Sat Apr 30 22:07:10 CEST 2011
Dear Andre Schwarz,
In message <1302785522-14393-1-git-send-email-andre.schwarz at matrix-vision.de> you wrote:
>
> Signed-off-by: Andre Schwarz <andre.schwarz at matrix-vision.de>
It appears this commit contains some unrelated changes?
> - "static_ipaddr", "static_netmask", "static_gateway",
> + "static_ipaddr", "static_netmask", "static_gateway", "boot_sqfs",
...like this.
> int mv_load_fpga(void)
> {
> - int result;
> + int result = -1;
> +#ifdef CONFIG_FPGA
> size_t data_size = 0;
> void *fpga_data = NULL;
> char *datastr = getenv("fpgadata");
> @@ -92,6 +92,7 @@ int mv_load_fpga(void)
> }
>
> result = fpga_load(0, fpga_data, data_size);
> +#endif
... or that.
Please split into orthogonal changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Another dream that failed. There's nothing sadder.
-- Kirk, "This side of Paradise", stardate 3417.3
More information about the U-Boot
mailing list