[U-Boot] [PATCH] xilinx_emaclite.c ping-pong macro names

[Wolfgang Denk]

Dear alain.peteut at space.unibe.ch,

In message <20110415144908.16476jnz1wxcpps4 at mail.unibe.ch> you wrote:
>
> Please find attached the checked patch. Sorry for the inconvenience.

Please send patches inline. No attachments!

And please stick to the rules with updated versions - mark the
version in the Subject, and provide a Changelog.  See
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Also, please provide a meaningful Subject: and commit message - I have
to admit that I have no idea what this patch is suposed to be about.

>  /*
> - * TX - TX_PING & TX_PONG initialization
> +  TX - TX_PING & TX_PONG initialization
>   */

Why are you messing up a previously correct multinine comment into an
incorrect one?

Please undo.

>  	out_be32 (emaclite.baseaddress + XEL_TSR_OFFSET, 0);
> @@ -155,12 +157,13 @@ static int emaclite_init(struct eth_device *dev, bd_t > *bis)
>  	while ((in_be32 (emaclite.baseaddress + XEL_TSR_OFFSET) &
>  		XEL_TSR_PROG_MAC_ADDR) != 0) ;
>  
> -#ifdef CONFIG_XILINX_EMACLITE_TX_PING_PONG
> +#ifdef XILINX_EMACLITE_TX_PING_PONG

Why are you making this change?  Configurable parameteres are supposed
to start with CONFIG_ resp. CONFIG_SYS_ ?

> -	out_be32 (emaclite.baseaddress + XEL_TPLR_OFFSET, ENET_ADDR_LENGTH);
> +	out_be32 (emaclite.baseaddress + XEL_TPLR_OFFSET + XEL_BUFFER_OFFSET,
> +		ENET_ADDR_LENGTH);

This change appears to be unrelated to macro names.  Please split
into separate patches, and provde information what you change and why.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
PUBLIC NOTICE AS REQUIRED BY LAW:  Any Use of This  Product,  in  Any
Manner  Whatsoever,  Will  Increase  the  Amount  of  Disorder in the
Universe. Although No Liability Is Implied Herein,  the  Consumer  Is
Warned  That  This  Process Will Ultimately Lead to the Heat Death of
the Universe.