[U-Boot] [PATCH 2/5] powerpc/85xx: Add FMan ethernet support to P4080DS

[Wolfgang Denk]

Dear Kumar Gala,

In message <1312179825-27917-2-git-send-email-galak at kernel.crashing.org> you wrote:
> From: Andy Fleming <afleming at freescale.com>
> 
> Add support for RGMII, SGMII, and XAUI (10Gb) Ethernet on P4080DS.
> 
> The board supports add-on cards for SGMII and XAUI functionality.  Which
> slots on the board these cards are in is a function of the SERDES option
> selected and muxes on the board.
> 
> Additionally because of the high-configurablity which MDIO bus one is
> connected to is "selected" via an FPGA register.  We create dummy MDIO
> bus for the phy layer and hide the mux manipulation in this dummy layer.
> 
> Add fman fdt helper function in board common code it'll be used by several
> freescale boards that do various muxing of the MDIO signals based on which
> controller/interface one is trying to talk to.
> 
> Removed CONFIG_SYS_FMAN_FW as its not used anywhere.
> 
> Signed-off-by: Mingkai Hu <Mingkai.hu at freescale.com>
> Signed-off-by: Andy Fleming <afleming at freescale.com>
> Signed-off-by: Timur Tabi <timur at freescale.com>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>

Checkpatch says:

WARNING: externs should be avoided in .c files
#259: FILE: board/freescale/corenet_ds/corenet_ds.c:223:
+extern void fdt_fixup_board_enet(void *blob);

Please move to header file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii)
        "That we but teach bloody instructions,
        which, being taught, return to plague the inventor..."