[U-Boot] [PATCH v2 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all'

Joel A Fernandes agnel.joel at gmail.com
Wed Aug 17 01:38:59 CEST 2011


Fix for only one led getting set or reset when the led_name is 'all'

Previous discussion:
http://lists.denx.de/pipermail/u-boot/2011-May/093068.html

Changes since v1:
Fixed checkpatch if statement error noticed by Sergei.

Signed-off-by: Joel A Fernandes <agnel.joel at gmail.com>
Signed-off-by: Jason Kridner <jkridner at beagleboard.org>
Cc: Sergei Shtylyov <sshtylyov at mvista.com>
---
 common/cmd_led.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/common/cmd_led.c b/common/cmd_led.c
index d14dd5a..183dc0b 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -108,7 +108,9 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			} else {
 				__led_set(led_commands[i].mask, state);
 			}
-			break;
+			/* Need to set only 1 led if led_name wasn't 'all' */
+			if (strcmp("all", argv[1]) != 0)
+				break;
 		}
 	}
 
-- 
1.7.1



More information about the U-Boot mailing list