[U-Boot] [PATCH v6 1/2] gpio: Add GPIO driver framework for Marvell SoCs

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: Tuesday, August 16, 2011 11:31 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ajay Bhargav
> Subject: [PATCH v6 1/2] gpio: Add GPIO driver framework for Marvell SoCs
> 
> This patch adds generic GPIO driver framework support for Marvell SoCs.
> 
> To enable GPIO driver define CONFIG_MARVELL_GPIO and for GPIO commands
> define CONFIG_CMD_GPIO in your board configuration file.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> ---
> Changes for v2:
> 	- mvgpio.h removed
> 	- function get_gpio_base moved to gpio.h
> 	- error messages added
> Changes for v3:
> 	- Added mvgpio.h for common define based on CPU core subversion.
> Changes for v4:
> 	- not changed
> Changes for v5:
> 	- Added change history
> Changes for v6:
> 	- Renamed GPIO level defines (fixes compilation issues thanks to
> 	  Lei Wen)
> 
>  drivers/gpio/Makefile |    1 +
>  drivers/gpio/mvgpio.c |  114
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  include/mvgpio.h      |   77 +++++++++++++++++++++++++++++++++

Hi Ajay
I am sorry if I missed this in my earlier reviews.

Why you wish to keep mvgpio.h in /include folder?
I think it should be in drivers/gpio/.

Regards..
Prafulla . .