[U-Boot] [PATCH v6 1/2] gpio: Add GPIO driver framework for Marvell SoCs

Ajay Bhargav ajay.bhargav at einfochips.com
Wed Aug 17 10:48:16 CEST 2011


----- "Prafulla Wadaskar" <prafulla at marvell.com> wrote:

> Hi Ajay
> I am sorry if I missed this in my earlier reviews.
> 
> Why you wish to keep mvgpio.h in /include folder?
> I think it should be in drivers/gpio/.
> 
> Regards..
> Prafulla . .
> 

Hi Prafulla,

gpio.h includes this file, as GPIO_LEVEL_SET/CLR are defined
in mvgpio.h which may be needed by other files accessing gpios.
In my case I am using gpio for PHY reset. I was thinking not to
keep any magic number 1/0 for set/clr gpio pin.

Regards,
Ajay Bhargav


More information about the U-Boot mailing list