[U-Boot] [PATCH 07/14] MX5: efikamx: make use of GPIO framework

Stefano Babic sbabic at denx.de
Mon Aug 22 13:15:52 CEST 2011


On 08/21/2011 01:54 PM, Marek Vasut wrote:
> On Sunday, August 21, 2011 12:28:22 PM Stefano Babic wrote:
>> Signed-off-by: Stefano Babic <sbabic at denx.de>
>> CC: Marek Vasut <marek.vasut at gmail.com>
>> ---

Hi Marek,

>> +	gpio_direction_output(IOMUX_TO_GPIO(MX51_PIN_CSI1_HSYNC), 0);
> 
> I'd be careful about the LEDs here.

Well, I have seen the LEDs were not explicitely initialized. Maybe it
relies on the default value of the DR register, that should be zero.

> Anyway, I'll try to test it sometimes soon 
> (begining of next week is ok?).

Of course, yes. Thanks for testing !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list