[U-Boot] [PATCH 07/14] MX5: efikamx: make use of GPIO framework

Marek Vasut marek.vasut at gmail.com
Mon Aug 22 14:28:04 CEST 2011


On Monday, August 22, 2011 01:15:52 PM Stefano Babic wrote:
> On 08/21/2011 01:54 PM, Marek Vasut wrote:
> > On Sunday, August 21, 2011 12:28:22 PM Stefano Babic wrote:
> >> Signed-off-by: Stefano Babic <sbabic at denx.de>
> >> CC: Marek Vasut <marek.vasut at gmail.com>
> >> ---
> 
> Hi Marek,
> 
> >> +	gpio_direction_output(IOMUX_TO_GPIO(MX51_PIN_CSI1_HSYNC), 0);
> > 
> > I'd be careful about the LEDs here.
> 
> Well, I have seen the LEDs were not explicitely initialized. Maybe it
> relies on the default value of the DR register, that should be zero.
> 
> > Anyway, I'll try to test it sometimes soon
> > (begining of next week is ok?).
> 
> Of course, yes. Thanks for testing !

Well damn, my efikamx didn't arrive today as planned. You can merge it, according 
to the schematics it looks ok.

Cheers

> 
> Best regards,
> Stefano Babic


More information about the U-Boot mailing list