[U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

Ajay Bhargav ajay.bhargav at einfochips.com
Tue Aug 23 14:59:49 CEST 2011


----- "Wolfgang Denk" <wd at denx.de> wrote:

> Dear Ajay Bhargav,
> 
> In message
> <1058764603.122757.1314095393033.JavaMail.root at ahm.einfochips.com> you
> wrote:
> > 
> > > I think someone NAKed this whole part with MAC randomisation and
> he was right 
> > > about it ... you're supposed to configure the MAC properly
> yourself.
> ...
> > MAC randomization is done in U-Boot by many already. I am
> 
> U-Boot is big and contains lots of poor code. And many people have a
> strange skill of always picking poor examples only when copying code.
> So it always makes sense to double-check.
> 
> > confused... just like i was when working with GPIO :) Is it
> something
> > which has changed lately?
> 
> No, this has not changed lately.
> 
> Just re-read Mike's message:
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106117
> 
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> It seems intuitively obvious to me, which  means  that  it  might  be
> wrong.                                                 -- Chris Torek
> 
Dear Wolfgang,

ok I just wanted to clear myself.. I do not have a dedicated hardware
storage in my ethernet controller so I will just look into environment
variable ethaddr, if its set I will just copy it to driver layer and
if it is not set, I let the user set it. He/She may use the tools provided
with U-Boot to generate a random MAC or by any mean get a MAC and store it
in env which is gonna be one time unless env gets corrupt or cleared by user.
Which means no MAC generation in code...

Please correct me if my understanding wrong...

Thanks & Regards,
Ajay Bhargav


More information about the U-Boot mailing list