[U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

[Wolfgang Denk]

Dear Ajay Bhargav,

In message <1570238601.123783.1314104389736.JavaMail.root at ahm.einfochips.com> you wrote:
> 
> ok I just wanted to clear myself.. I do not have a dedicated hardware
> storage in my ethernet controller so I will just look into environment
> variable ethaddr, if its set I will just copy it to driver layer and
> if it is not set, I let the user set it. He/She may use the tools provided
> with U-Boot to generate a random MAC or by any mean get a MAC and store it
> in env which is gonna be one time unless env gets corrupt or cleared by user.
> Which means no MAC generation in code...
> 
> Please correct me if my understanding wrong...

This is correct, except for the nitpick that nobody should ever use a
truly random MAC address - if no valid MAC address is available, one
should at least make sure to pick one of the locally administered
Ethernet address pool (2nd LSB in the most significant byte of the
address must be set).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If anything can go wrong, it will."                   - Edsel Murphy