[U-Boot] [PATCH 7/7] powerpc/8xxx: Add support for interactive DDR programming interface

[Wolfgang Denk]

Dear York Sun,

In message <1312923045-2612-7-git-send-email-yorksun at freescale.com> you wrote:
> Interactive DDR debugging provides a user interface to view and modify SPD,
> DIMM parameters, board options and DDR controller registers before DDR is
> initialized. With this feature, developers can fine-tune DDR for board
> bringup and other debugging without frequently having to reprogram the flash.
> 
> To enable this feature, define CONFIG_FSL_DDR_INTERACTIVE in board header
> file and set an environment variable to activate it. Syntax:
...

Checkpatch says:

WARNING: do not add new typedefs
WARNING: plain inline is preferred over __inline__
WARNING: do not add new typedefs

Please fix!

...
> +/* Option parameter Structures */
> +typedef struct {
> +	const char *option_name;
> +	size_t offset;
> +	unsigned int size;
> +	const char printHex;

We don't allow CamelCase identifiers.  Please fix globally.


...
> +			/*
> +			 * FIXME: For some reason printing this whole
> +			 * thing causes the machine to freeze.
> +			 * Splitting it into two printfs seems to make
> +			 * it work. Does printf() have limits on the
> +			 * length of the string?
> +			 */

Please fix this before submitting.

> +			printf(
> +	"commands:\n"
> +	"print      print SPD and intermediate computed data\n"
> +	"reset      reboot machine\n"
> +	"recompute  reload SPD and options to default and recompute regs\n");
> +			printf(
> +	"edit       modify spd, parameter, or option\n");
> +			printf(
> +	"compute    recompute registers from current next_step to end\n"
> +	"next_step  shows current next_step\n"
> +	"help       this message\n"
> +	"go         program the memory controller and continue with u-boot\n");
> +			continue;
> +		}

Incorrect indentation.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't tell me how hard you work.  Tell me how much you get done.
- James J. Ling