[U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

[Wolfgang Denk]

Dear York Sun,

In message <1314378058.20734.25.camel at oslab-l1> you wrote:
> 
> I am going to follow the style and not to add new typedefs. For the
> existing typedef, I will keep using them. In this case, it is an
> existing typedef, just for another platform. Fixing it alone will cause
> more troubles.

I understand why you would prefer such an interpretation...  But the
fact is, you are adding new code that contains typedef's (and it does
not matter at all if other code in other places does the same or not).


Please don't misunderstand me - I can accept if you prefer not to fix
this problem now, but rather address it later, in a separate patch.
But it is technically wrong to claim you were not adding new
typedef's.   Checkpatch complains not without reason.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"An organization dries up if you don't challenge it with growth."
       - Mark Shepherd, former President and CEO of Texas Instruments