[U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

York Sun yorksun at freescale.com
Fri Aug 26 20:15:29 CEST 2011


On Fri, 2011-08-26 at 20:12 +0200, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1314378058.20734.25.camel at oslab-l1> you wrote:
> > 
> > I am going to follow the style and not to add new typedefs. For the
> > existing typedef, I will keep using them. In this case, it is an
> > existing typedef, just for another platform. Fixing it alone will cause
> > more troubles.
> 
> I understand why you would prefer such an interpretation...  But the
> fact is, you are adding new code that contains typedef's (and it does
> not matter at all if other code in other places does the same or not).
> 
> 
> Please don't misunderstand me - I can accept if you prefer not to fix
> this problem now, but rather address it later, in a separate patch.
> But it is technically wrong to claim you were not adding new
> typedef's.   Checkpatch complains not without reason.
> 

OK. I do prefer not to fix it now if you can accept it. Are you implying
we should fix all the existing typedefs? That will be a lot of cleanup.

York






More information about the U-Boot mailing list