[U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum CPU-A011 on e500mc cores

Wolfgang Denk wd at denx.de
Sat Aug 27 15:41:55 CEST 2011


Dear Kumar Gala,

In message <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2 at kernel.crashing.org> you wrote:
> 
> Any suggestions on how to do this? - comment it out?
> 
> /* #define CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 */

That would be dead code.

You don't want to add all possible #defines to your config files, do
you?  This is not a good weay to document your code.

Apropos documentation - I did not see that you explain
CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 (or any other of the ton of
CONFIG_SYS_FSL_ERRATUM_* you have) in the readme, or elsewehere.

_This_ is what you should fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"


More information about the U-Boot mailing list