[U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum CPU-A011 on e500mc cores

Kumar Gala galak at kernel.crashing.org
Sat Aug 27 18:09:06 CEST 2011


On Aug 27, 2011, at 8:41 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2 at kernel.crashing.org> you wrote:
>> 
>> Any suggestions on how to do this? - comment it out?
>> 
>> /* #define CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 */
> 
> That would be dead code.
> 
> You don't want to add all possible #defines to your config files, do
> you?  This is not a good weay to document your code.

Gotcha.

> 
> Apropos documentation - I did not see that you explain
> CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 (or any other of the ton of
> CONFIG_SYS_FSL_ERRATUM_* you have) in the readme, or elsewehere.
> 
> _This_ is what you should fix.

I'll add a general comment about CONFIG_SYS_FSL_ERRATUM_* in README and a new doc/README.fsl-ppc-errata if that sounds good.

- k


More information about the U-Boot mailing list