[U-Boot] [RFC PATCH] Pre-console buffer for ARM

Mike Frysinger vapier at gentoo.org
Mon Aug 29 21:20:27 CEST 2011


On Monday, August 29, 2011 13:21:57 Simon Glass wrote:
> +void pre_console_putc(const char c)
> +{
> +	char *buffer =  (char *)CONFIG_SYS_TMP_CON_BUF_ADDR;

excess space after the "="

> +	if (gd->con_buf_idx < CONFIG_SYS_TMP_CON_BUF_SZ)
> +		buffer[gd->con_buf_idx++] = c;

seems like a circular buffer would make more sense ... usually the part of the 
log you want is the last chunk and not the first
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110829/0404f2e3/attachment.pgp 


More information about the U-Boot mailing list