[U-Boot] [RFC PATCH] Pre-console buffer for ARM

[Simon Glass]

Hi Mike,

On Mon, Aug 29, 2011 at 12:20 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday, August 29, 2011 13:21:57 Simon Glass wrote:
>> +void pre_console_putc(const char c)
>> +{
>> +     char *buffer =  (char *)CONFIG_SYS_TMP_CON_BUF_ADDR;
>
> excess space after the "="

Thanks - I will leave this to Graeme to tidy as our patches overlap
(and most of the patch is just his).

>
>> +     if (gd->con_buf_idx < CONFIG_SYS_TMP_CON_BUF_SZ)
>> +             buffer[gd->con_buf_idx++] = c;
>
> seems like a circular buffer would make more sense ... usually the part of the
> log you want is the last chunk and not the first

Yes I agree, although if you have more than 1KB of data it might be a bug.

Regards,
SImon

> -mike
>