[U-Boot] [PATCH v6] ulpi: add generic ULPI functionality

Igor Grinberg grinberg at compulab.co.il
Thu Dec 1 12:12:12 CET 2011


On 11/28/11 21:43, Jana Rapava wrote:
> Add generic functions for reading, writing and setting bits in ULPI registers.
> 
> Signed-off-by: Jana Rapava <fermata7 at gmail.com>
> Cc: Remy Bohmer <linux at bohmer.net>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Igor Grinberg <grinberg at compulab.co.il>
> Cc: Wolfgang Grandegger <wg at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> 
> Acked-by: Igor Grinberg <grinberg at compulab.co.il>
> Acked-by: Simon Glass <sjg at chromium.org>
> ---
> Changes for v2:
>       - make code EHCI-independent
>       - use udelay() in waiting loop
>       - mark static functions as static
>       - naming changes
> Changes for v3:
>        - merge with patch ulpi: add generic ULPI support header file
>        - rewrite ULPI interface in more functionality-oriented way
> Changes for v4:
>        - add error-checking
>        - add waiting for completion into ulpi_reset() function
> Changes for v5:
>         - CodingStyle changes
>         - add comments
>         - simplify implemenation of the ULPI interface functions
> Changes for v6:
> 	- cleanup function ulpi_drive_vbus()

Lately, I've found several flaws in v6.
Those are a "no goes" as for me.
I've got Jana's permission to take over the patch and
I will submit a reworked version soon (hopefully tomorrow).

-- 
Regards,
Igor.


More information about the U-Boot mailing list