[U-Boot] [PATCH 10/14] board/mpl/common/flash.c: Fix GCC 4.6 build warning

Wolfgang Denk wd at denx.de
Fri Dec 2 00:15:54 CET 2011


Dear Marek Vasut,

In message <201112012314.25106.marek.vasut at gmail.com> you wrote:
> > Fix:
> > ../common/flash.c: In function 'flash_init':
> > ../common/flash.c:160:16: warning: variable 'size_b1' set but not used
> > [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Wolfgang Denk <wd at denx.de>
> > Cc: Denis Peter <d.peter at mpl.ch>
> > ---
> > ERROR: space required after that ',' (ctx:VxV)
> > #26: FILE: board/mpl/common/flash.c:160:
> > +	unsigned long flashcr,size_reg;
> >  	                     ^
> > 
> > total: 1 errors, 0 warnings, 15 lines checked
> > 
> > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> > MULTISTATEMENT_MACRO_USE_DO_WHILE
> > 
> > Error ignored.  No further cleanup attempted.
...

> > -	unsigned long size_b1,flashcr,size_reg;
> > +	unsigned long flashcr,size_reg;
> 
> Can you please add space after the comma (", ") ? Thank you.

No. I intentionally don't start cleaning up this file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How do you play religious roulette?
A:  You stand around in a circle  and  blaspheme  and  see  who  gets
    struck by lightning first.


More information about the U-Boot mailing list