[U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets
Mike Frysinger
vapier at gentoo.org
Sat Dec 3 18:03:50 CET 2011
On Saturday 03 December 2011 04:36:32 Marek Vasut wrote:
> > On Saturday 03 December 2011 03:23:28 Marek Vasut wrote:
> > > > On Saturday 03 December 2011 02:32:03 Marek Vasut wrote:
> > > > > + if [ "$ONLY_LIST" == 'y' ] ; then return ; fi
> > > >
> > > > [ "$ONLY_LIST" = "y" ] && return
> > >
> > > I prefer to be explicit.
> >
> > my version is "explicit" as well
> >
> > the point was more that if statements shouldn't be one-liners like that.
> > if you want to keep it, then unwrap the block.
>
> Is there any such rule?
i don't think we have a style guide for shell scripts, but what you're
proposing doesn't show up anywhere in the current tree. and it's ugly :P.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111203/ba2e5bb3/attachment.pgp>
More information about the U-Boot
mailing list