[U-Boot] [PATCH] MIPS: fix endianess handling

Wolfgang Denk wd at denx.de
Sun Dec 4 16:08:59 CET 2011


Dear Shinya Kuribayashi,

In message <4EDB8475.1080305 at pobox.com> you wrote:
>
> >> -pb1000                       mips        mips32      pb1x00              -              au1x00      pb1x00:PB1000
> >> +pb1000                       mips        mips32      pb1x00              -              au1x00      pb1x00:PB1000,SYS_LITTLE_ENDIAN
...
> But I don't see any reason CONFIG_SYS_LITTLE_ENDIAN is specified in
> boards.cfg.  Just putting it in configs/pb1000.h is enough, isn't it?

Agreed.  In almost all cases this should be done in the board config
file only.  Only if there are cases where a board suppors both LE and
BE configurations (is there any such board??) then we should need a
SYS_*_ENDIAN setting in boards.cfg (but even then, only one - not
two).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real computer scientists don't comment their  code.  The  identifiers
are so long they can't afford the disk space.


More information about the U-Boot mailing list