[U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

Anatolij Gustschin agust at denx.de
Mon Dec 5 17:32:30 CET 2011


On Mon, 5 Dec 2011 08:02:53 -0700
Tom Rini <trini at ti.com> wrote:

> On 12/03/2011 09:46 AM, Anatolij Gustschin wrote:
> > Fix:
> > clocks-common.c: In function 'setup_dplls':
> > clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
> > [-Wunused-but-set-variable]
> > clocks-common.c: In function 'setup_non_essential_dplls':
> > clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
> > [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Anatolij Gustschin <agust at denx.de>
> > Cc: sricharan <r.sricharan at ti.com>
> > Cc: Tom Rini <trini at ti.com>
> > ---
> >  arch/arm/cpu/armv7/omap-common/clocks-common.c |    8 +++-----
> >  1 files changed, 3 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c
> > index 1e7e20e..1da90a4 100644
> > --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
> > +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
> > @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
> >  
> >  static void setup_dplls(void)
> >  {
> > -	u32 sysclk_ind, temp;
> > +	u32 temp;
> >  	const struct dpll_params *params;
> > -	debug("setup_dplls\n");
> >  
> > -	sysclk_ind = get_sys_clk_index();
> > +	debug("setup_dplls\n");
> >  
> >  	/* CORE dpll */
> >  	params = get_core_dpll_params();	/* default - safest */
> 
> Hand-editing the diffs?  Not sure why the debug print looks like it
> moved.  But regardless...

No, not this time. I moved the debug print intentionally to fix the
coding style, while at it. It doesn't make sense to send separate
patch for this coding style fix. I should have mentioned this in the
commit log, sorry.

Thanks for review!

Anatolij


More information about the U-Boot mailing list