[U-Boot] [PATCH V7 5/5] omap-common: fixes BSS overwriting problem

Wolfgang Denk wd at denx.de
Tue Dec 6 19:21:50 CET 2011


Dear Simon Schwarz,

In message <4EDE56AB.3070504 at gmail.com> you wrote:
>
> Why not use malloc for this? Thanks to changes in the FAT driver we now 
> have it in the SPL.

No, please do NOT do that!!!

I knew I should have never accepted to allow this in the SPL fromt he
beginning, and indeed it was a mistake not to block this.

Please now don't use it without thinking if it's really, really
needed!


I recommend NOT to use malloc() at all in SPL code.

[Guess I should have a more carefull eye on all SPL related
submissions and install a "grep-malloc-and-NAK" script. :-( ]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only perfect science is hind-sight.


More information about the U-Boot mailing list