[U-Boot] [PATCH 1/2] Include common.h in qsort.c to fix build warning

Simon Glass sjg at chromium.org
Wed Dec 7 06:29:38 CET 2011


Hi Kumar,

On Tue, Dec 6, 2011 at 7:36 PM, Kumar Gala <galak at kernel.crashing.org> wrote:
>
> On Dec 6, 2011, at 5:37 PM, Simon Glass wrote:
>
>> exports.h no longer includes common.h, which contains assert(). qsort.c
>> needs to be updated. This fixes this warning:
>>
>> qsort.c: In function 'qsort':
>> qsort.c:30:3: warning: implicit declaration of function 'assert' [-Wimplicit-function-declaration]
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>> lib/qsort.c |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Acked-by: Kumar Gala <galak at kernel.crashing.org>
>
> ---
>
> w/o this we actually have compile failure with the tree:
>
> In file included from qsort.c:19:0:
> /local/home/galak/git/u-boot/include/exports.h:19:27: error: expected declaration specifiers or '...' before 'va_list'
> qsort.c: In function 'qsort':
> qsort.c:30:3: warning: implicit declaration of function 'assert'
>

Yes I was trying to be polite :-)

Regards,
Simon

>
> - k


More information about the U-Boot mailing list