[U-Boot] [PATCH/RFC] gen_atmel_mci: add mci_set_data_timeout()

[Andreas Bießmann]

Dear Andy Fleming,

Am 14.10.2011 14:36, schrieb Andreas Bießmann:
> Before the DTOR register is set to a fixed value and resulted in some cards
> not working. Setting the fixed value to a hihger value is not appropriate
> cause we could wait way to long for slow clock rates.
> 
> This patch moves the mci_set_data_timeout() from old atmel_mci driver to
> gen_atmel_mci driver and adopts to the parameters. In contrast to the origin
> this version of mci_set_data_timeout() relies on some fixed input values for
> timeout_ns and timeout_clks. Before these values where taken from the card's
> CSD.
> 
> Signed-off-by: Andreas Bießmann <biessmann at corscience.de>
> CC: Sven Schnelle <svens at stackframe.org>
> CC: Reinhard Meyer <u-boot at emk-elektronik.de>
> CC: Andy Fleming <afleming at gmail.com>
> ---
> RESENT TO LIST ...
> 
> This is an RFC. The most questionary thing is whether we use fixed values for
> timeout_ns/timeout_clks or take the values from CSD as before.
> 
> I wonder if we should add the taac and nsac values to the mmc struct or if we
> should handle the mmc->csd[] inside the driver if we requiore the card data as
> input for the timeout equtation.
> 
> Please read also http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/112056/focus=112057

This is the patch in question (see discussion @
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/119611/focus=119626)

Is it OK for you to use the fixed values for timeout_ns/timeout_clks
here or should we
 a) use the mmc->csd[] values in the respective driver?
or
 b) introduce some generic handling for mmc->csd[]?

best regards

Andreas Bießmann