[U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

[Stefano Babic]

On 07/12/2011 19:45, Wolfgang Denk wrote:
> Dear Ilya Yanok,
> 
> In message <4EDFA65E.8080809 at emcraft.com> you wrote:
>>
>>> boards, we could at least use a #warn message to advise at compile time
>>> that a default value is taken (and at the end, to force the board
>>> maintainers to fix it...).
>>
>> Probably. Wolfgang, Scott, do you think we should add a warning here?
> 
> How much space are we talking about?  Can it be put on the stack?
> 

I think we are talking about 24 bytes, getting the value for
CONFIG_SYS_NAND_ECCTOTAL in the configuration file.

Reading the code it is not clear to me why the computed ecc is stored in
this way at a fixed offset in RAM - anybody knows why cannot we set a
static char ecc_calc[] at the beginning of the nand_spl_simple.c file ?

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================