[U-Boot] [PATCH] arm: Tegra: fix undefined instruction hang immediately after reset

[Mike Frysinger]

On Tuesday 06 December 2011 18:00:19 Tom Warren wrote:
> commit 0d479b53 (Aneesh V) added code for OMAP4 that doesn't
> execute on Tegra, due to the AVP (ARM7TDI) not having a CP15.
> Result was an undefined instruction hang just after reset.
> 
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> 
> +#if !defined(CONFIG_TEGRA2)
>  /*
>   * Setup vector:
>   * (OMAP4 spl TEXT_BASE is not 32 byte aligned.
> @@ -159,6 +160,7 @@ reset:
>  	ldr	r0, =_start
>  	mcr	p15, 0, r0, c12, c0, 0	@Set VBAR
>  #endif
> +#endif	/* !Tegra2 */

forgive my ignorance, but would it be better to invert the logic ?  have ARM 
cores that do have a CP15 define CONFIG_ARM_CP15 (or whatever) and then put all 
this logic behind that rather than grow a list of SoC's that lack it ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111207/1e908f4f/attachment.pgp>