[U-Boot] [PATCH V9 4/4] omap-common/spl: Add linux boot to SPL

Tom Rini tom.rini at gmail.com
Thu Dec 8 02:09:13 CET 2011


On Wed, Dec 7, 2011 at 5:50 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday 06 December 2011 13:34:38 Simon Schwarz wrote:
>> --- a/arch/arm/cpu/armv7/omap-common/spl.c
>> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
>>
>> +void jump_to_image_linux(void *arg)
>> +{
>> ...
>> +}
>> +void jump_to_image_linux(void *) __attribute__ ((noreturn));
>
> no need for this.  do it in one line:
> __noreturn void jump_to_image_linux(void *arg)
> {
>        ...
> }
>
> (include linux/compiler.h if need be)

Style?  I prefer the single line version myself but I've seen lots of
the long form when poking around before.

-- 
Tom


More information about the U-Boot mailing list