[U-Boot] [PATCH 01/13] davinci_emac: move arch-independent defines to separate header

Tom Rini tom.rini at gmail.com
Thu Dec 8 15:42:19 CET 2011


On Thu, Dec 8, 2011 at 7:33 AM, Igor Grinberg <grinberg at compulab.co.il> wrote:
> On 12/08/11 01:48, Ilya Yanok wrote:
>> Hi Igor,
>>
>> sorry for the late answer.
>>
>> On 30.11.2011 11:42, Igor Grinberg wrote:
>>>> diff --git a/arch/arm/cpu/arm926ejs/davinci/dp83848.c b/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>>>> index c71c685..d435e4b 100644
>>>> --- a/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>>>> +++ b/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>>>> @@ -29,6 +29,7 @@
>>>>  #include <net.h>
>>>>  #include <dp83848.h>
>>>>  #include <asm/arch/emac_defs.h>
>>>> +#include "../../../../../drivers/net/davinci_emac.h"
>>>
>>> Doesn't this look terrible?
>>
>> Yes, it does. But this will be removed once someone will switch the
>> driver to phylib.
>
> Hmmm... and who will be that someone?
> Is it on someone's TODO list?

With my TI hat on, me.

-- 
Tom


More information about the U-Boot mailing list