[U-Boot] [RFC PATCH 3/7] reboard: Add generic relocation feature

Simon Glass sjg at chromium.org
Fri Dec 9 04:36:52 CET 2011


Hi,

On Wed, Dec 7, 2011 at 4:35 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Wednesday 07 December 2011 02:38:40 Albert ARIBAUD wrote:
>> Le 30/11/2011 03:58, Mike Frysinger a écrit :
>> > On Tuesday 29 November 2011 18:49:58 Graeme Russ wrote:
>> >> On Wed, Nov 30, 2011 at 10:41 AM, Simon Glass wrote:
>> >>> On Tue, Nov 29, 2011 at 3:20 PM, Mike Frysinger wrote:
>> >>>> On Tuesday 29 November 2011 17:15:18 Simon Glass wrote:
>> >>>>> On Mon, Nov 28, 2011 at 7:07 PM, Mike Frysinger wrote:
>> >>>>>> On Monday 21 November 2011 18:57:56 Simon Glass wrote:
>> >>>>>>> --- /dev/null
>> >>>>>>> +++ b/board/Makefile
>> >>>>>>>
>> >>>>>>> +ifndef CONFIG_SYS_LEGACY_BOARD
>> >>>>>>> +COBJS        += reloc.o
>> >>>>>>> +endif
>> >>>>>>
>> >>>>>> i don't think relocation should be tied "legacy board".  not all
>> >>>>>> arches do relocation at all, which means they might never opt in to
>> >>>>>> this aspect.
>> >>>>>
>> >>>>> If they don't do reloc then when we move them over we should add a
>> >>>>> CONFIG for this I think. But would prefer to wait until we have an
>> >>>>> arch moving over that requires no relocation, before addressing this.
>> >>>>
>> >>>> Blackfin does no relocation, so i'd be annoyed to have to carry a
>> >>>> define like "LEGACY_BOARD" forever ;)
>> >>>
>> >>> Would you be happier with CONFIG_ARCH_NO_RELOCATION?
>> >>
>> >> CONFIG_SYS_NO_RELOC
>> >
>> > either is fine by me
>>
>> CONFIG_SYS_SKIP_RELOC clearly states there is some usual step we're
>> skipping, plus we could homogeneize with other config settings that
>> "SKIP" some step.
>
> fine by me as well
> -mike

OK, will define that in boards with no relocation. Others (like
PowerPC) will end up with an unused relocation function until they
switch over. That might cause problems, we will see.

Regards,
Simon


More information about the U-Boot mailing list